Open
Conversation
- Fix mdUI info parsing. It assumed that the mdUI info can only appears in SP entities, and it tried to get the fields from there without checking if the SP variable actually exists. Now it tries to use a SP, and if it doesn't exist it falls back to an IdP. - Improve location parsing. It tries to split the location using ',' and if it can't then tries using '/'. If it still can't get the location data then it gives up and assume there is no location data instead of entering an infinite recursion loop that produced an error.
Contributor
Author
|
I have added another fix related to the mdui to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appears in SP entities, and it tried to get the fields from there
without checking if the SP variable actually exists. Now it tries
to use a SP, and if it doesn't exist it falls back to an IdP.
',' and if it can't then tries using '/'. If it still can't get
the location data then it gives up and assume there is no location
data instead of entering an infinite recursion loop that produced
an error.