added group and period to elements#21
Open
asturur wants to merge 2 commits intoandrejewski:masterfrom
Open
Conversation
|
Great pull, one note, cobalt has a group of 19 in your data rather than 9 and boron is showing as period 1, not two. Cheers! |
Author
|
hey! i forgot about this. maybe i found a bad source? i ll double check. |
Owner
|
@asturur @eagletommy52 I can't accept this PR because the JSON file is built from the underlying CSV. I'm open to removing the CSV entirely to make collaboration easier, but that should be its own PR/discussion. Also, I highly encourage you both to check out #22 if you are interested in this project. |
Author
|
ok i ll look better at the build process then. i do not remember what i did to be honest. was 6 month ago |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I was using this data for an exercise and i realized having group and period specified could have been handy