Finish migrating away from usage of six

[andrewleech]

This completes the migration started in PR #47 by removing all remaining references to the six library and replacing them with native Python 3 standard library imports.

Changes:

• Replace six.moves.BaseHTTPServer with http.server
• Replace six.moves.socketserver with socketserver
• Remove six from setup.py install_requires

Files modified:

• pywebdav/lib/utils.py: Import BaseHTTPRequestHandler from http.server
• pywebdav/server/server.py: Import HTTPServer and ThreadingMixIn from stdlib
• pywebdav/lib/AuthServer.py: Replace all six.moves.BaseHTTPServer references
• setup.py: Remove six dependency

All imports verified to work correctly with Python 3.

[claude]

Code Review - PR #52: Complete removal of six compatibility library

Summary

This PR successfully completes the migration away from the six compatibility library by replacing the remaining six.moves imports with native Python 3 standard library equivalents.

Positives

Code Quality

• Clean imports: All imports are correctly updated to use Python 3 standard library (six.moves.BaseHTTPServer to http.server, six.moves.socketserver to socketserver)
• Consistent changes: All four modified files follow the same migration pattern
• No remaining six references: Verified that no other six imports remain in the codebase
• Correct syntax: All imports use proper Python 3 syntax

Dependencies

• Dependency cleanup: Removing six from install_requires in setup.py eliminates an unnecessary dependency, reducing the package footprint

Areas for Consideration

1. Python Version Compatibility

The imports used are available in Python 3.x, but the README.md states Python 3.5 or higher as a requirement. Consider updating setup.py to include python_requires to formally declare this.

2. Testing

• The test suite (test/test_litmus.py) appears comprehensive and imports the modified server module
• Recommendation: Run the test suite to ensure these import changes don't break functionality

3. Empty install_requires

setup.py now has install_requires = []. This is correct if there are truly no dependencies, but worth double-checking if any other runtime dependencies exist.

Potential Issues

No bugs or security concerns identified in this PR. The changes are straightforward module replacements.

Performance Considerations

No performance impact expected. The Python 3 standard library modules are the native implementations and should perform equivalently or better than the six.moves wrappers.

Security Assessment

No security concerns. The changes are purely import updates with no behavioral modifications.

Recommendations

1. Add python_requires to setup.py to formally declare Python 3.5+ requirement
2. Run the existing test suite to verify compatibility (test/test_litmus.py)
3. Consider adding a CHANGELOG entry documenting the removal of the six dependency
4. Verify CI/CD pipelines (if any) still pass with these changes

Overall Assessment

Approval Status: Recommend Approval with Minor Testing

This is a clean, well-executed PR that completes an important modernization step. The changes are:

• Correct and idiomatic for Python 3
• Consistent across all modified files
• Reduce external dependencies
• Align with the project's Python 3 focus (PyWebDAV3)

The only requirement before merging is to run the test suite to ensure no regressions were introduced. Once tests pass, this PR is ready to merge.

Related Context

This PR builds on PR #47 which started the six removal process. Based on the pyflakes output mentioned in PR #47 description, there appear to be other undefined name issues in the codebase (in davcopy.py, iface.py, etc.), but those are separate from this PR and should be addressed independently.

Great work completing this migration!