Sync changes from internal dev branch.

[lip-liu]

code sync for release of 2.6.1

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the naming convention for file transfer speed metrics within the codebase. The change updates a dictionary key from 'speed_mbps' to 'speed_MBps', enhancing clarity and consistency in how this performance indicator is represented and utilized across different modules.

Highlights

• Naming Convention Standardization: Standardized the dictionary key for file transfer speed from 'speed_mbps' to 'speed_MBps' in both test reporting and utility functions to ensure consistent capitalization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• betocq/nearby_connection/function_tests/beto_cq_function_group_test.py
  • Updated the 'properties' dictionary key from 'speed_mbps' to 'speed_MBps' when recording single test case reports.
• betocq/test_result_utils.py
  • Modified the dictionary key from 'speed_mbps' to 'speed_MBps' in the '_summarize_transfer_quality_info' function.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the dictionary key for transfer speed from speed_mbps to speed_MBps. While this change aims to clarify that the unit is MegaBytes per second, it introduces a naming inconsistency with other snake_case keys in the project. My review suggests using a more consistent key name, such as speed_mb_per_s, to adhere to PEP 8 naming conventions while retaining clarity.

I am having trouble creating individual review comments. Click here to see my feedback.

betocq/nearby_connection/function_tests/beto_cq_function_group_test.py (508)

The dictionary key 'speed_MBps' deviates from the snake_case naming convention used for other keys in this project, which is also recommended by PEP 8 for variables. To improve consistency and readability, please consider renaming it to something like speed_mb_per_s.

      properties['speed_mb_per_s'] = (

References

1. PEP 8 recommends snake_case for variable names. Applying this convention to dictionary keys, especially when other keys already follow it, enhances code consistency and maintainability. The key 'speed_MBps' is an exception to this pattern. ^(link)

betocq/test_result_utils.py (704)

The dictionary key 'speed_MBps' is inconsistent with other keys in this dictionary, such as 'discovery_latency' and 'speed_mbps_iperf', which follow the snake_case naming convention (PEP 8). To improve maintainability, I suggest renaming it for consistency, for example to speed_mb_per_s.

      'speed_mb_per_s': _float_to_str(

References

1. PEP 8 recommends snake_case for variable names. In this dictionary, most keys follow this convention. The key 'speed_MBps' is an exception, which reduces consistency. A uniform naming style for keys is preferable for maintainability. ^(link)