Sync changes from internal dev branch.

[lip-liu]

a bug fix

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine synchronization of changes from an internal development branch. The primary impact is an update to a specific Wi-Fi Direct test configuration, transitioning it to utilize a DFS-enabled 5GHz STA type. This ensures that the test environment accurately reflects the intended Wi-Fi capabilities and compliance requirements.

Highlights

• Wi-Fi D2D Type Update: Updated the WifiD2DType from XCC_5G_STA to XCC_5G_DFS_STA in the setup_class method of the xcc_wfd_dfs_5g_sta_test.py file. This change affects both the setup_wifi_env and WifiInfo.from_test_parameters calls, aligning the test configuration with DFS-enabled 5GHz STA mode.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• betocq/nearby_connection/directed_tests/xcc_wfd_dfs_5g_sta_test.py
  • Updated the d2d_type parameter in the setup_wifi_env function call from XCC_5G_STA to XCC_5G_DFS_STA.
  • Modified the d2d_type parameter in the WifiInfo.from_test_parameters function call from XCC_5G_STA to XCC_5G_DFS_STA.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the d2d_type from XCC_5G_STA to XCC_5G_DFS_STA in xcc_wfd_dfs_5g_sta_test.py. This change aligns the test configuration with its purpose, which is to test scenarios involving DFS 5G STA, as indicated by the file name and class documentation. I've added a suggestion to refactor the duplicated constant for better maintainability.

[gemini-code-assist]

To improve maintainability and avoid duplicating the d2d_type constant, you could define it once in a local variable and reuse it.

    d2d_type = nc_constants.WifiD2DType.XCC_5G_DFS_STA
    self.setup_wifi_env(
        d2d_type=d2d_type,
        country_code=_COUNTRY_CODE,
    )
    self.wifi_info = nc_constants.WifiInfo.from_test_parameters(
        d2d_type=d2d_type,
        params=self.test_parameters,
    )