Sync changes from internal dev branch.

[lip-liu]

fix a minor bug

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the management of Wi-Fi and Bluetooth firmware versions for Android devices within the testing utilities. The changes aim to centralize device-specific information by moving firmware version storage into a dedicated dictionary and updating retrieval logic to consistently access these details from the new centralized location, improving data consistency and maintainability.

Highlights

• Centralized Firmware Storage: Modified setup_android_device_for_nc_tests to store Wi-Fi and Bluetooth firmware versions within a device_specific_dict instead of directly on the Android device object, promoting a more organized approach to device-specific data.
• Unified Firmware Retrieval: Updated _get_device_attributes to retrieve Wi-Fi and Bluetooth firmware versions from the device_specific_info dictionary, aligning with the new storage mechanism and including a fallback to directly querying the device if the information is not present.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• betocq/nearby_connection/utils.py
  • Changed the storage location for Wi-Fi and Bluetooth firmware versions from direct device attributes on the Android device object to the device_specific_dict.
• betocq/test_result_utils.py
  • Updated the logic to retrieve Wi-Fi and Bluetooth firmware versions by first checking the device_specific_info dictionary, with a fallback to directly querying the device if the information is not found.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors how device-specific information, like firmware versions, is stored. It moves from monkey-patching AndroidDevice instances to using a shared dictionary, which is a good structural improvement. My review identifies a minor inefficiency in a fallback scenario where firmware versions are retrieved but not cached, potentially leading to repeated slow operations. I've included a suggestion to cache these values to improve performance.

[gemini-code-assist]

This logic fetches the Wi-Fi and Bluetooth firmware versions if they are not already cached in device_specific_info. However, it doesn't store the newly fetched versions back into the cache. This means that every time _get_device_attributes is called, it could result in repeated, potentially slow adb calls to fetch the firmware versions if they weren't populated during the initial setup.

To improve efficiency, you should cache the firmware versions after fetching them.

  wifi_fw = device_specific_info.get('wifi_fw', '')
  if not wifi_fw:
    wifi_fw = setup_utils.get_wifi_firmware_version(ad)
    device_specific_info['wifi_fw'] = wifi_fw
  bt_fw = device_specific_info.get('bt_fw', '')
  if not bt_fw:
    bt_fw = setup_utils.get_bt_firmware_version(ad)
    device_specific_info['bt_fw'] = bt_fw