Update config for AQT

[lip-liu]

Remove the hardware capabilities dependency for AQT test suite.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the AQT test suite configuration to reduce its dependency on specific hardware capabilities and device configurations. By introducing a generic controller alias and updating network credentials, the changes aim to make the test suite more flexible and easier to run across different Android devices without requiring explicit hardware capability declarations.

Highlights

• Configuration Update: Updated Wi-Fi network credentials (SSIDs and passwords) to generic 'betocq' values for 2G, 5G, and DFS 5G networks.
• Generic Controller Alias: Introduced a new 'non_specified_controllers' alias to allow AQT testbeds to use any Android device, removing the dependency on specific device serial numbers.
• Hardware Capability Streamlining: Removed explicit 'supports_5g' flags from device configurations, streamlining hardware capability declarations.
• DFS Channel Support: Enabled 'enable_sta_dfs_channel_for_peer_network' for both source and target devices, allowing WFD group owner on STA-associated DFS channels.
• AQT Testbed Configuration: Configured 'Aqt' and 'AqtDebug' testbeds to utilize the new 'non_specified_controllers' alias, aligning with the goal of reducing hardware dependency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• betocq/cuj_and_test_config.yml
  • Updated Wi-Fi SSID and password values for 2G, 5G, and DFS 5G networks.
  • Added a new 'x-controllers' alias 'non_specified_controllers' to allow any Android device.
  • Removed the 'supports_5g' boolean flag from device configurations.
  • Changed 'enable_sta_dfs_channel_for_peer_network' to 'True' for both devices.
  • Modified the 'Aqt' and 'AqtDebug' testbeds to use the 'non_specified_controllers' alias.

Activity

• Pull request created by lip-liu.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the configuration for the AQT test suite to remove the dependency on specific hardware capabilities, which is a good change for flexibility. However, I've found a critical issue in the YAML configuration where a key is duplicated, which can lead to parsing errors or unexpected behavior. I've also pointed out a couple of typos in comments. Please review the specific comments for details and suggestions.

[gemini-code-assist]

The YAML key x-controllers is defined again on line 21. Duplicate keys are invalid in YAML and can lead to unpredictable behavior or parsing errors. To fix this, you should use a unique key for the non_specified_controllers anchor.

x-non_specified_controllers: &non_specified_controllers

[gemini-code-assist]

There is a typo in the comment. It should be wifi_chipset instead of wifi_chiset.

        # wifi_chipset must be specified, otherwise the test will fail.

[gemini-code-assist]

There is a typo in the comment. It should be wifi_chipset instead of wifi_chiset.

        # wifi_chipset must be specified, otherwise the test will fail.