Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Dependencies updated, build fixed. #30

Open
syslogic wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Dependencies updated, build fixed. #30

syslogic wants to merge 9 commits into from

Conversation

@syslogic
Copy link

@syslogic syslogic commented Oct 25, 2019

No description provided.

@omeryounus
Copy link

omeryounus commented Oct 25, 2019

@syslogic Just out of curiosity why do we need to format it??

@syslogic
Copy link
Author

syslogic commented Oct 25, 2019 •
edited
Loading

R.string.sets_format is the one formatted text in the header, eg. Sets: 1/6. While the lack of the attribute formatted="false" prevented the build, because it rejected the (otherwise) positional format %d/%d. Without that exclusion, it won't process the resources - or generate class BR.

@syslogic
Copy link
Author

syslogic commented Oct 25, 2019 •
edited
Loading

I've fixed the reference to class BR, which closes #27 & probably #28. Also fixed most Gradle & Lint warnings.

@syslogic syslogic changed the title Dependencies updated, TwoWaySample build fixed. Dependencies updated, build fixed. Oct 25, 2019
@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@omeryounus omeryounus omeryounus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@syslogic @omeryounus