Re-layout dialog after textarea is loaded to fix scroll behaviour#29
Open
lukasvice wants to merge 1 commit intoandykirk:masterfrom
Open
Re-layout dialog after textarea is loaded to fix scroll behaviour#29lukasvice wants to merge 1 commit intoandykirk:masterfrom
lukasvice wants to merge 1 commit intoandykirk:masterfrom
Conversation
Owner
|
Ah, I understand. Thanks for this. It's really helpful. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding #12
CKEditor handles the position of the dialog correctly even if the viewport is smaller than the dialog.
The problem was that the initialization of the footnote's CKEditor changed the height of the dialog after the dialog's layouting. If that happens, a re-layout of the dialog is necessary to fix the position of the dialog.