Set local storage before it get it fully#32
Open
varticvasile wants to merge 3 commits intoandyperlitch:masterfrom
Open
Set local storage before it get it fully#32varticvasile wants to merge 3 commits intoandyperlitch:masterfrom
varticvasile wants to merge 3 commits intoandyperlitch:masterfrom
Conversation
varticvasile
force-pushed
the
defect/wrongSaveToLocaleSorage
branch
from
b32fb81 to
7b4fa0f
Compare
Owner
|
@varticvasile do you think adding the check for the existence of columns to the |
Contributor
Author
|
Yes i did. but it's used in more cases than those 3. |
Owner
|
Is the problem that |
Contributor
Author
|
The problem is that saveToStorage is called before the loadFromStorage has finish. and sets the storage with default data. Not with the last data. |
varticvasile
force-pushed
the
defect/wrongSaveToLocaleSorage
branch
from
6542602 to
5437126
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.