fix(IRSB): removed wrong instruction_addresses calculaion from lift…#521
Open
DanielBotnik wants to merge 1 commit intoangr:masterfrom
Open
fix(IRSB): removed wrong instruction_addresses calculaion from lift…#521DanielBotnik wants to merge 1 commit intoangr:masterfrom
instruction_addresses calculaion from lift…#521DanielBotnik wants to merge 1 commit intoangr:masterfrom
Conversation
172457c to
ad16eb8
Compare
…, now only deriving from statments
ad16eb8 to
9f1b597
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had one of the weirds bug while using pyvex on one of my binaries, I found out that the irsb don't count addresses after empty IMark for some reason, but letting it recalcualtes it works fine.
Now I also noticed that there was multiple addresses, so I made sure only to include IMARK with
lengreater than 0. this seemed to solve the problem