Undefined array key "t"... (if exists tag "x=" without tag "t=")#14
Open
blackstormlab wants to merge 21 commits intoangrychimp:masterfrom
Open
Undefined array key "t"... (if exists tag "x=" without tag "t=")#14blackstormlab wants to merge 21 commits intoangrychimp:masterfrom
blackstormlab wants to merge 21 commits intoangrychimp:masterfrom
Conversation
…me being, add license and disclamer, suggest original package.
…ins about it. As soon as original package updates this dependency to recent release (2.x+), this should be reverted.
Reason: If email content file is pulled directly from Maildir on Linux, it has body newlines separated by \n rather than \r\n which is what mail systems use internally (unverified claim!). This broke validation.
Merging original licensing info, as specified by original author: angrychimp#5
Fix DKIM signatures ending with a semicolon
The value of the "x=" tag MUST be greater than the value of the "t=" tag if both are present.
Author
|
this is my first PR i don't know if i did it right. all that needs fixing is that one line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Validator.php): if ((int) $dkimTags['x'] < (int) $dkimTags['t']) {
MUST BE:
if ( isset($dkimTags['t']) && ((int) $dkimTags['x'] < (int) $dkimTags['t']) ) {
The value of the "x=" tag MUST be greater than the value of the "t=" tag if both are present.