This repository was archived by the owner on May 25, 2019. It is now read-only.
Fix multiple compilations from duplicating items in ng-repeat#13
Open
runxc1 wants to merge 1 commit intoangular-ui:masterfrom
Open
Fix multiple compilations from duplicating items in ng-repeat#13runxc1 wants to merge 1 commit intoangular-ui:masterfrom
runxc1 wants to merge 1 commit intoangular-ui:masterfrom
Conversation
Member
|
Think you could add a unit test or 2 to show this fixes the bug in question? |
|
Do we need the compile flag & check at all? It seems that simply commenting out lines 73-78 in the original works as expected. EDIT: Found that it needs to compile once or else ng-click won't work. Don't need to decorate the infoWindow.open() though; compiling once in the link function seems to suffice. See Valorum@327d7ef |
|
Can this pull request being merged or the Valorum's one... The issue is still happening |
|
This fix works for me, it has stopped the event handlers from multiplying. |
|
+1 |
|
@Valorum fix worked fine for me, please accept that |
|
Any update on if this will be accepted? - its been open for over a year now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12