This repository was archived by the owner on May 25, 2019. It is now read-only.
angular-ui-map doesnt play well with angular-ui-router. #35
Open
SayreBlades wants to merge 3 commits intoangular-ui:masterfrom
Open
angular-ui-map doesnt play well with angular-ui-router. #35SayreBlades wants to merge 3 commits intoangular-ui:masterfrom
SayreBlades wants to merge 3 commits intoangular-ui:masterfrom
Conversation
delays constrution of the google map until the page has been loaded.
Contributor
|
This looks like a very specific and inflexible solution to a very general problem. What if UI Router and UI Map are combined with another module that controls template rendering (let's say, a tab directive)? Now you have to listen for two events. What if they don't agree about whether the map should be rendered? What if the order of events is nondeterministic? 👎 from me. A logical approach would use a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables delayed construction of the google map component until the page has been loaded.