Merged
Conversation
Contributor
Wicpar
commented
Jan 15, 2026
Wicpar
commented
- new ts12 draft compliant changes
- added utils for correct metadata merging
Member
|
I can merge without tests passing, but if the type check fails the publhsing won't work. Can you take a look? |
TimoGlastra
approved these changes
Jan 16, 2026
| .catchall(z.string().max(40).nullable()) | ||
| .refine( | ||
| (data) => { | ||
| return Object.keys(data).length <= 11 |
Member
There was a problem hiding this comment.
is this in the spec? Do you have a link to the updated spec?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
but yes it is in the specs, as discussed with the ts12 team, but this is not validated yet, it may take a bit
| return resolved as ResolvedTs12Metadata | ||
| } | ||
|
|
||
| export const baseMergeConfig = { |
Contributor
Author
There was a problem hiding this comment.
so, wanna have it in credo-ts or sd-jwt-vc ?
Co-authored-by: Timo Glastra <timo@animo.id>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.