GH-942: Fix JDBC Connection.setCatalog() #943
Merged
+131
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eickler
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Apologies for the larger than needed PR. I couldn't get the tests passing without running spotless:apply and for some reason that reformatted parts that I did not even touch. |
lidavidm
approved these changes
Jan 5, 2026
Member
|
CC @jbonofre @laurentgo any comments? |
jbonofre
approved these changes
Jan 5, 2026
| statementHandlePreparedStatementMap.remove(new StatementHandleKey(statementHandle)); | ||
| // Testing if the prepared statement was created because the statement can be not created until | ||
| // Testing if the prepared statement was created because the statement can be | ||
| // not created until |
Member
There was a problem hiding this comment.
nit: this change is unecessary (I guess it's due to reformating)
| return new ExecuteResult(Collections.singletonList(metaResultSet)); | ||
| } catch (SQLTimeoutException e) { | ||
| // So far AvaticaStatement(executeInternal) only handles NoSuchStatement and Runtime | ||
| // So far AvaticaStatement(executeInternal) only handles NoSuchStatement and |
Member
|
LGTM, I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Connection.setCatalog() is not silently ignored anymore (through the default implementation in Calcite) but instead it updates the catalog session option in the same way as during the initial connection.
Closes #942.