GH-47196: [CI][C++] Add Windows ARM64 build by jgiannuzzi · Pull Request #47811 · apache/arrow

jgiannuzzi · 2025-10-14T09:32:26Z

Rationale for this change

This PR adds a CI job to test building the C++ library on Windows ARM64 with MSVC, which will help ensuring that downstream projects like vcpkg can build Arrow C++ on that platform.

What changes are included in this PR?

The windows job from the cpp.yml workflow has been moved into a reusable workflow cpp_windows.yml
Use GitHub hosted runner windows-11-arm to build with MSVC ARM64 in cpp_extra.yml
simd-level is set NONE for now as xsimd does not yet support MSVC ARM64
msys2 is installed and used for the timezone data, as it is not guaranteed to exist on windows-11-arm images
A recent version of cmake is installed as support for finding Windows OpenSSL ARM64 builds was only added in 4.1.0 (see Kitware/CMake@bf52219)
The Boost context implementation is set to winfib when building with MSVC ARM64 as it's the only supported implementation for that platform (see Windows ARM64 Support boostorg/context#296 (comment) and Add Windows ARM64 support boostorg/context#315)

Are these changes tested?

Yes, in the CI itself

Are there any user-facing changes?

No

GitHub Issue: [C++][CI] Add a C++ Windows ARM64 CI Job #47196

github-actions · 2025-10-14T09:32:52Z

⚠️ GitHub issue #47196 has been automatically assigned in GitHub to PR creator.

jgiannuzzi · 2025-10-14T09:33:50Z

~~This PR currently depends on #47779 for the new CI job to succeed, hence why I set it as draft.~~

github-actions · 2025-10-14T11:50:42Z

⚠️ GitHub issue #47196 has been automatically assigned in GitHub to PR creator.

github-actions · 2025-10-14T12:23:20Z

⚠️ GitHub issue #47196 has been automatically assigned in GitHub to PR creator.

pitrou · 2025-10-15T15:22:55Z

Can this be made part of the "C++ Extra" workflows? We probably don't want to support this officially for now, do we?
@kou

jgiannuzzi · 2025-10-15T16:55:08Z

@pitrou @raulcd @kou if you are all fine with the duplication between the "C++" Windows MSVC x64 job and the "C++ Extra" Windows MSVC arm64 job (as they are more or less identical), I'm happy to move it there!

kou

Yes. Could you use cpp_extra.yml?

BTW, @pitrou could you start a discussion (and a vote?) for #46002 on dev@arrow.apache.org to clarify our support policy?

kou · 2025-10-16T00:50:28Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

+  if(MSVC AND "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ARM64")
+    set(BOOST_CONTEXT_IMPLEMENTATION
+        winfib
+        CACHE STRING "" FORCE)


Do we need to use CACHE variable here?

Yes, otherwise it will default to fcontext and the build will fail. If cmake is run a second time after the initial configuration failed, somehow it then works. I thus decided to use CACHE FORCE to make it more reliable.

Hmm. Could you try CMP0126 https://cmake.org/cmake/help/latest/policy/CMP0126.html and normal (not cache) variable?

diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index e805694f52..ca6b9e8746 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -71,6 +71,12 @@ cmake_policy(SET CMP0090 NEW) # MSVC runtime library flags are selected by an abstraction. cmake_policy(SET CMP0091 NEW) +# https://cmake.org/cmake/help/latest/policy/CMP0126.html +# +# The set(CACHE) command does not remove any normal variable of the +# same name from the current scope. +cmake_policy(SET CMP0126 NEW) + # https://cmake.org/cmake/help/latest/policy/CMP0135.html # # CMP0135 is for solving re-building and re-downloading.

sadly it didn't work :/

ci/scripts/install_cmake.sh

.github/workflows/cpp.yml

.github/workflows/cpp_extra.yml

ci/scripts/install_cmake.sh

kou · 2025-10-17T02:11:55Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

+  if(MSVC AND "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ARM64")
+    set(BOOST_CONTEXT_IMPLEMENTATION
+        winfib
+        CACHE STRING "" FORCE)


Hmm. Could you try CMP0126 https://cmake.org/cmake/help/latest/policy/CMP0126.html and normal (not cache) variable?

diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index e805694f52..ca6b9e8746 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -71,6 +71,12 @@ cmake_policy(SET CMP0090 NEW) # MSVC runtime library flags are selected by an abstraction. cmake_policy(SET CMP0091 NEW) +# https://cmake.org/cmake/help/latest/policy/CMP0126.html +# +# The set(CACHE) command does not remove any normal variable of the +# same name from the current scope. +cmake_policy(SET CMP0126 NEW) + # https://cmake.org/cmake/help/latest/policy/CMP0135.html # # CMP0135 is for solving re-building and re-downloading.

jgiannuzzi · 2025-10-21T17:32:49Z

@pitrou @AntoinePrv #47573 has broken the Windows ARM64 MSVC build. I have addressed it in 3fb046c, but happy to create a separate PR for it if you want.

github-actions · 2025-10-21T17:36:59Z

⚠️ GitHub issue #47196 has been automatically assigned in GitHub to PR creator.

kou

+1

It may be better that we split the bpacking_simd changes to a separated PR. @WillAyd may have a comment for the Meson part.

kou · 2025-10-22T06:23:05Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

+  if(MSVC AND "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ARM64")
+    set(BOOST_CONTEXT_IMPLEMENTATION
+        winfib
+        CACHE STRING "" FORCE)


.github/workflows/cpp_extra.yml

pitrou · 2025-10-22T11:03:50Z

It may be better that we split the bpacking_simd changes to a separated PR

+1 for splitting indeed

jgiannuzzi · 2025-10-22T11:50:01Z

@pitrou @WillAyd @AntoinePrv split into #47910

### Rationale for this change #47573 broke the Windows ARM64 MSVC build by trying to compile xsimd even when `ARROW_SIMD_LEVEL` is set to `NONE`. ### What changes are included in this PR? Make sure that xsimd is only included when SIMD is requested. ### Are these changes tested? Yes, in the Windows ARM64 MSVC build pipeline that I was developing on #47811 when I noticed the change. ### Are there any user-facing changes? No. * GitHub Issue: #47909 Authored-by: Jonathan Giannuzzi <jonathan@giannuzzi.me> Signed-off-by: Antoine Pitrou <antoine@python.org>

- Use GitHub hosted runner `windows-11-arm` to build with MSVC ARM64 - `simd-level` is set `NONE` for now as xsimd does not yet support MSVC ARM64 - `msys2` is installed and used for the timezone data, as it is not guaranteed to exist on windows-11-arm images - A recent version of `cmake` is installed as support for finding Windows OpenSSL ARM64 builds was only added in 4.1.0 (see Kitware/CMake@bf52219) - The Boost context implementation is set to `winfib` when building with MSVC ARM64 as it's the only supported implementation for that platform (see boostorg/context#296 (comment) and boostorg/context#315) - Updated ccache installation script and version to enable a Windows ARM64 native version

jgiannuzzi · 2025-10-22T15:58:15Z

Rebased after the merge of #47910 and included @kou's latest comments around naming

kou

+1

conbench-apache-arrow · 2025-10-23T08:07:56Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8dd9eba.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 57 possible false positives for unstable benchmarks that are known to sometimes produce them.

### Rationale for this change apache#47573 broke the Windows ARM64 MSVC build by trying to compile xsimd even when `ARROW_SIMD_LEVEL` is set to `NONE`. ### What changes are included in this PR? Make sure that xsimd is only included when SIMD is requested. ### Are these changes tested? Yes, in the Windows ARM64 MSVC build pipeline that I was developing on apache#47811 when I noticed the change. ### Are there any user-facing changes? No. * GitHub Issue: apache#47909 Authored-by: Jonathan Giannuzzi <jonathan@giannuzzi.me> Signed-off-by: Antoine Pitrou <antoine@python.org>

### Rationale for this change This PR adds a CI job to test building the C++ library on Windows ARM64 with MSVC, which will help ensuring that downstream projects like [`vcpkg`](https://github.com/microsoft/vcpkg) can build Arrow C++ on that platform. ### What changes are included in this PR? - The `windows` job from the `cpp.yml` workflow has been moved into a reusable workflow `cpp_windows.yml` - Use GitHub hosted runner `windows-11-arm` to build with MSVC ARM64 in `cpp_extra.yml` - `simd-level` is set `NONE` for now as xsimd does not yet support MSVC ARM64 - `msys2` is installed and used for the timezone data, as it is not guaranteed to exist on `windows-11-arm` images - A recent version of `cmake` is installed as support for finding Windows OpenSSL ARM64 builds was only added in 4.1.0 (see Kitware/CMake@bf52219) - The Boost context implementation is set to `winfib` when building with MSVC ARM64 as it's the only supported implementation for that platform (see boostorg/context#296 (comment) and boostorg/context#315) ### Are these changes tested? Yes, in the CI itself ### Are there any user-facing changes? No * GitHub Issue: apache#47196 Authored-by: Jonathan Giannuzzi <jonathan@giannuzzi.me> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

github-actions bot added Component: C++ awaiting review Awaiting review labels Oct 14, 2025

jgiannuzzi mentioned this pull request Oct 14, 2025

[C++] Make Arrow C++ buildable with MSVC on Windows ARM64 #47784

Closed

jgiannuzzi force-pushed the windows-arm64-cpp-ci branch from 0522a37 to 9a8b0a5 Compare October 14, 2025 09:55

jgiannuzzi force-pushed the windows-arm64-cpp-ci branch from 9a8b0a5 to 9ce6253 Compare October 14, 2025 17:39

jgiannuzzi mentioned this pull request Oct 15, 2025

GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics #47779

Merged

jgiannuzzi force-pushed the windows-arm64-cpp-ci branch from 9ce6253 to 84f64cf Compare October 15, 2025 13:22

github-actions bot added the Component: Documentation label Oct 15, 2025

jgiannuzzi force-pushed the windows-arm64-cpp-ci branch from 84f64cf to d2a3efd Compare October 15, 2025 15:19

github-actions bot removed the Component: Documentation label Oct 15, 2025

jgiannuzzi marked this pull request as ready for review October 15, 2025 15:20

jgiannuzzi requested review from assignUser, jonkeane, kou and raulcd as code owners October 15, 2025 15:20

kou reviewed Oct 16, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 16, 2025

jgiannuzzi force-pushed the windows-arm64-cpp-ci branch from d2a3efd to e861fdc Compare October 16, 2025 14:11

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 16, 2025

kou reviewed Oct 17, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Oct 17, 2025

jgiannuzzi force-pushed the windows-arm64-cpp-ci branch from e861fdc to 4d7e0b3 Compare October 21, 2025 17:28

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 21, 2025

kou approved these changes Oct 22, 2025

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Oct 22, 2025

jgiannuzzi mentioned this pull request Oct 22, 2025

GH-47909: [C++] Fix MSVC ARM64 build #47910

Merged

jgiannuzzi force-pushed the windows-arm64-cpp-ci branch from 4d7e0b3 to fc90543 Compare October 22, 2025 14:38

jgiannuzzi force-pushed the windows-arm64-cpp-ci branch from fc90543 to 8f8edd7 Compare October 22, 2025 15:52

jgiannuzzi force-pushed the windows-arm64-cpp-ci branch from 8f8edd7 to e859997 Compare October 22, 2025 15:53

kou approved these changes Oct 23, 2025

View reviewed changes

kou merged commit 8dd9eba into apache:main Oct 23, 2025
42 of 44 checks passed

kou removed the awaiting merge Awaiting merge label Oct 23, 2025

github-actions bot added the awaiting merge Awaiting merge label Oct 23, 2025

kou mentioned this pull request Oct 23, 2025

[C++][CI] Add a C++ Windows ARM64 CI Job #47196

Closed

jgiannuzzi deleted the windows-arm64-cpp-ci branch October 23, 2025 11:32

Conversation

jgiannuzzi commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

jgiannuzzi commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

pitrou commented Oct 15, 2025

Uh oh!

jgiannuzzi commented Oct 15, 2025

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

kou Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

jgiannuzzi Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

kou Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

jgiannuzzi Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

kou Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kou Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

jgiannuzzi commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

kou Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pitrou commented Oct 22, 2025

Uh oh!

jgiannuzzi commented Oct 22, 2025

Uh oh!

jgiannuzzi commented Oct 22, 2025

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

conbench-apache-arrow bot commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jgiannuzzi commented Oct 14, 2025 •

edited

Loading

jgiannuzzi commented Oct 14, 2025 •

edited

Loading

jgiannuzzi commented Oct 21, 2025 •

edited

Loading