ATLAS-5056: Entity audit should not be created for instances of internal entity-types #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-gupta36
force-pushed
the
ATLAS-5056
branch
from
a6bd585 to
5a3d893
Compare
aditya-gupta36
force-pushed
the
ATLAS-5056
branch
from
5a3d893 to
5bbda87
Compare
chaitalicod
reviewed
Dec 19, 2025
| return true; | ||
| } | ||
|
|
||
| // Skip audit if ALL entities are internal types (__AtlasAuditEntry, __AtlasMetricsStat, etc.) |
Contributor
There was a problem hiding this comment.
check if you can make your comments more precise and short?
chaitalicod
reviewed
Dec 19, 2025
Contributor
chaitalicod
left a comment
chaitalicod
left a comment
There was a problem hiding this comment.
Please update the section for testing
How was this patch tested?
aditya-gupta36
force-pushed
the
ATLAS-5056
branch
from
5bbda87 to
29d7838
Compare
aditya-gupta36
force-pushed
the
ATLAS-5056
branch
from
29d7838 to
5c65890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before fix:
skipAuditEntries(): false → audit processing proceeds
EntityAuditListenerV2.onEntitiesAdded appears → audit entries created
After fix:
skipAuditEntries(): true (allInternal=true) → early exit
No notifyV2Listeners log → processing skipped
No EntityAuditListenerV2.onEntitiesAdded log → no audit entries created
How was this patch tested?