CASSANDRA-18221: Add AccordConfig to track accord specific configs #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcapwell
requested changes
Apr 4, 2023
| final List<Instance> instances = new CopyOnWriteArrayList<>(); | ||
|
|
||
| public SimpleProgressLog(Node node) | ||
| public SimpleProgressLog(Node node, AccordConfig config) |
Contributor
There was a problem hiding this comment.
should Node expose config? That way you don't need to pass all over?
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| import accord.utils.AccordConfig; |
Contributor
There was a problem hiding this comment.
I feel we should have accord.config package, this is likely to expand over time
|
|
||
| isScheduled = true; | ||
| node.scheduler().once(() -> commandStore.execute(PreLoadContext.empty(), ignore -> run()).begin(commandStore.agent()), 200L, TimeUnit.MILLISECONDS); | ||
| node.scheduler().once(() -> commandStore.execute(PreLoadContext.empty(), ignore -> run()).begin(commandStore.agent()), config.progress_log_scheduler_delay_in_ms, TimeUnit.MILLISECONDS); |
Contributor
There was a problem hiding this comment.
we are trying to move away from _in_ms postfix... this may call out that we should likely move some of the config classes to accord?
Comment on lines
+6
to
+8
| public AccordConfig(long progress_log_scheduler_delay_in_ms) { | ||
| this.progress_log_scheduler_delay_in_ms = progress_log_scheduler_delay_in_ms; | ||
| } |
Contributor
There was a problem hiding this comment.
this constructor isn't something we can maintain, as we add more and more configs this will become an issue
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
6a9482b to
4a8566a
Compare
belliottsmith
force-pushed
the
trunk
branch
9 times, most recently
from
c3a1d8f to
efc6a38
Compare
belliottsmith
force-pushed
the
trunk
branch
3 times, most recently
from
289d5ea to
064735b
Compare
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
2edc7fb to
a271897
Compare
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
50d6ef9 to
bd0761c
Compare
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
183d5d0 to
cd7f495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Kamalesh Palanisamy;