Skip to content

CASSANDRA-21065: Fix ConcurrentModificationException in performGarbageCollection with only_purge_repaired_tombstones #4571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joaquincasares wants to merge 10 commits into
base: trunk
Choose a base branch
from
+573 −1
Open

CASSANDRA-21065: Fix ConcurrentModificationException in performGarbageCollection with only_purge_repaired_tombstones #4571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b61905
CASSANDRA-21065: Fix ConcurrentModificationException in GC compaction…
joaquincasares Jan 19, 2026
46fda6b
CASSANDRA-21065: Add tests for GC compaction with mixed repaired/unre…
joaquincasares Jan 19, 2026
72875ad
CASSANDRA-21065: Add Docker setup for running unit tests
joaquincasares Jan 19, 2026
0863c11
clear test output from previous runs
joaquincasares Jan 19, 2026
6fde361
move extra text from README to PR description
joaquincasares Jan 19, 2026
70d62f8
add license text
joaquincasares Jan 19, 2026
9a2e275
Apply suggestions from Mick's code review
joaquincasares Jan 21, 2026
33a6dbb
Clean up comments in GarbageCollectRepairedSSTablesTest
joaquincasares Jan 21, 2026
9b35fd0
remove redundant docker testing container
joaquincasares Jan 21, 2026
b47afd7
finish rename
joaquincasares Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/java/org/apache/cassandra/db/compaction/CompactionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,9 @@ public Iterable<SSTableReader> filterSSTables(LifecycleTransaction transaction)
List<SSTableReader> filteredSSTables = new ArrayList<>();
if (cfStore.getCompactionStrategyManager().onlyPurgeRepairedTombstones())
{
for (SSTableReader sstable : transaction.originals())
// Copy originals to avoid ConcurrentModificationException when cancel()
// modifies the underlying collection when calling `cancel(..)`
for (SSTableReader sstable : new ArrayList<>(transaction.originals()))
{
if (!sstable.isRepaired())
{
Expand Down
Loading