Fix basicauth for credentials requiring percent encoding#364
Merged
Conversation
janl
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As reported in #363, when the CouchDB URL includes a username & password and those credentials contain characters that need to be "percent encoded", then Nano's auth failed. (It did work fine for session auth).
After investigation, it turns out that
new URL, the Node.js URL parser returns theusernameandpasswordstrings percent encoded. This meant that when these values were base64 encoded to become anAuthorizationheader, they contained the wrong data (but only for usernames and passwords with "special characters"). See https://nodejs.org/api/url.html#urlusername & https://nodejs.org/api/url.html#urlpassword.The solution is simple: just
decodeURIComponentthe values before base64 encoding them.Testing recommendations
Automated test added.
GitHub issue number
Fixes issue #363
Checklist