Improve docs and add examples for Visitor#778
Merged
alamb merged 4 commits intoapache:mainfrom Dec 29, 2022
Merged
Conversation
Contributor
Author
|
cc @tustvold |
Pull Request Test Coverage Report for Build 3800963580
💛 - Coveralls |
Contributor
Author
|
@tustvold do you have time to review this PR? I hope to merge this later today / make a release |
tustvold
approved these changes
Dec 29, 2022
| /// let mut visited = vec![]; | ||
| /// visit_relations(&statements, |relation| { | ||
| /// visited.push(format!("RELATION: {}", relation)); | ||
| /// ControlFlow::<()>::Continue(()) |
Contributor
There was a problem hiding this comment.
I'm surprised you need to type hint this
Contributor
Author
There was a problem hiding this comment.
Yeah, me too -- I think it is because the return value is not used
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on to #765