Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the integration test infrastructure by replacing a custom bash health check script with native Docker Compose health checks, using the --wait flag to ensure services are ready before running tests.
Changes:
- Replaced custom
docker-health-check.shscript with Docker Compose native health checks using the--waitflag - Added comprehensive health check configurations to all services in docker-compose.yml (zookeeper, nacos, polaris, etcd)
- Updated service images to specific versions (zookeeper 3.9.4, nacos v2.5.2, polaris v1.17.2) and standardized configurations (unified network, restart policies, volumes for etcd)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| start_integrate_test.sh | Replaced health check script invocation with docker compose up --wait command |
| docker-health-check.sh | Removed custom health check script with retry logic for all services |
| docker-compose.yml | Added native health checks for all services, updated image versions, added shared network 'itnet', standardized restart policies to 'unless-stopped', added etcd data volume |
| Makefile | Removed docker-health-check target that invoked the deleted script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexStocks
reviewed
Feb 19, 2026
Alanxtl
force-pushed
the
update_health_check
branch
from
d0a4e6d to
e19e3a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete health check script and use docker health check instead