Conversation
|
Kudos, SonarCloud Quality Gate passed! |
|
@carlvine500 Please update the following documentation accordingly: https://cn.dubbo.apache.org/zh-cn/overview/core-features/traffic/tag-rule/ |
ok. this is the pull request #2775 |
| String[] selectors = StringUtils.split(tagSelector, TAG_SEPERATOR); | ||
| for (int i = selectors.length; i > 0; i--) { | ||
| String selectorTmp = StringUtils.join(selectors, TAG_SEPERATOR, 0, i); | ||
| System.out.println(selectorTmp); |
There was a problem hiding this comment.
please remove System.out.println
ok
dubbo-dependencies-bom/pom.xml
Outdated
| <bytebuddy.version>1.14.5</bytebuddy.version> | ||
| <netty_version>3.2.10.Final</netty_version> | ||
| <netty4_version>4.1.92.Final</netty4_version> | ||
| <netty4_version>4.1.94.Final</netty4_version> |
There was a problem hiding this comment.
Why change the version?
a issue upgrade it , #12653
4.1.92.Final has vulnerability , CVE-2023-34462. Severity: MEDIUM
refer : https://mvnrepository.com/artifact/io.netty/netty-handler
wxbty
left a comment
There was a problem hiding this comment.
LGTM
btw, please resolve conflicts with the master
I have no permission to merge to (apache:3.3)apache:3.3 , but I have tried merge to my git : |
Merge apache:3.3 into your branch |
1b6e476 to
6d4d349
Compare
|
@AlbumenJ failing test is not about this pull_request . |








What is the purpose of the change
fix issue #12672
Brief changelog
tag with multi level will search tag as following:
requestTag=beta|team1|partner1
step0: if force=true , just search tag(beta|team1|partner1)
step1: search invokers with tag(beta|team1|partner1) , if result is empty , run step2
step2: search invokers with tag(beta|team1), if result is empty , run step3
step3: search invokers with tag(beta)
there are 10 deploy with tag=null and 10 deploy with dubbo.tag=beta, but my team just work with 8 deploy for a big feature-A , and my partners just work with 3 deploy for a small feature-A-1 :
my team want deploy 8 deploy with tag=beta|team1 , and share the deploy(tag=beta)
my partners want deploy 3 deploy with tag=beta|team1|partner1 , and share the deploy(tag=beta|team1)
Verifying this change
add some test case to search addresses with muti level tag
Checklist