This repository was archived by the owner on Jan 11, 2024. It is now read-only.
added extra layer to edit is_member status#172
Open
EGOR-IND wants to merge 1 commit intoapache:developmentfrom
Open
added extra layer to edit is_member status#172EGOR-IND wants to merge 1 commit intoapache:developmentfrom
EGOR-IND wants to merge 1 commit intoapache:developmentfrom
Conversation
|
|
||
| @OnCheckedChanged(R.id.cb_is_member) | ||
| void setIsMemberStatus() { | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { |
There was a problem hiding this comment.
All code looks good but we are supporting upto Android 4.1(API level 16) and this code wont work below Lollipop(API level 22). Wouldn't it lack change listener below Lollipop devices? Can't we have any alternative for lower levels compat version of check box. What do you say @EGOR-IND
Author
There was a problem hiding this comment.
Yeah, I'm finding a good option for api level less than lollipop. I'll add that patch very soon into this PR😊.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FINCN-306
WhatsApp.Video.2021-03-23.at.03.21.04.mp4
Added an extra layer to edit is_member status.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.