Add edit check to the edit activities#186
Add edit check to the edit activities#186EGOR-IND wants to merge 1 commit intoapache:developmentfrom
Conversation
| <string name="customer_edit_check_msg">Information not edited for the customer %1$s</string> | ||
| <string name="group_edit_check_msg">Information not edited for the group %1$s</string> | ||
| <string name="payroll_edit_check_msg">Information not edited for the payroll with customer identifier %1$s</string> | ||
| <string name="identification_edit_check_msg">Information not edited for the identification type %1$s</string> | ||
|
|
There was a problem hiding this comment.
@EGOR-IND Its good to check if user has changed so that unnecessary operations are not performed. But it would suggest that its ok if you dont notify user that he/she has not changed info as user would know it. Instead if user changed info save and exit and if not do quiet exit. What do you say are toasts mandatory?
There was a problem hiding this comment.
See I think toasts are good, I don't see any harm in that, it's just a simple indicatiin that they haven't change anything, I can add a dialog if you find snackbar inconvenient, the dialog can have an exit and cancel button, user can exit if they don't want any changes or they can simply press cancel and get back to the edit section. What do you think?
There was a problem hiding this comment.
I dont find toast bad but as you suggested it is better to confirm and save change if user edited or else it should show something like "You didn't change any data. Are you sure you want to exit?". It be probably better that this toast.
2 participants
Fixes #FINCN-315
WhatsApp.Video.2021-04-22.at.02.51.18.mp4
Added the edit check before making an update request from the edit activities.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.