Skip to content

Refactor varint constants for improved readability #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SYaoJun wants to merge 1 commit into
base: master
Choose a base branch
from
+28 −22
Open

Refactor varint constants for improved readability #744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 28 additions & 22 deletions ...w/geaflow-common/src/main/java/org/apache/geaflow/common/encoder/impl/IntegerEncoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,41 +27,47 @@ public class IntegerEncoder extends AbstractEncoder<Integer> {

public static final IntegerEncoder INSTANCE = new IntegerEncoder();

// VarInt encoding constants
private static final int VARINT_MASK = 0x7F;
private static final int VARINT_CONTINUE_FLAG = 0x80;
private static final int VARINT_SHIFT = 7;
private static final int DIRECT_WRITE_THRESHOLD = 128;

@Override
public void encode(Integer data, OutputStream outputStream) throws IOException {
// if between 0 ~ 127, just write the byte
if (data >= 0 && data < 128) {
if (data >= 0 && data < DIRECT_WRITE_THRESHOLD) {
outputStream.write(data);
return;
}

// write var int, takes 1 ~ 5 byte
int value = data;
int varInt = (value & 0x7F);
value >>>= 7;
int varInt = (value & VARINT_MASK);
value >>>= VARINT_SHIFT;

varInt |= 0x80;
varInt |= ((value & 0x7F) << 8);
value >>>= 7;
varInt |= VARINT_CONTINUE_FLAG;
varInt |= ((value & VARINT_MASK) << 8);
value >>>= VARINT_SHIFT;
if (value == 0) {
outputStream.write(varInt);
outputStream.write(varInt >> 8);
return;
}

varInt |= (0x80 << 8);
varInt |= ((value & 0x7F) << 16);
value >>>= 7;
varInt |= (VARINT_CONTINUE_FLAG << 8);
varInt |= ((value & VARINT_MASK) << 16);
value >>>= VARINT_SHIFT;
if (value == 0) {
outputStream.write(varInt);
outputStream.write(varInt >> 8);
outputStream.write(varInt >> 16);
return;
}

varInt |= (0x80 << 16);
varInt |= ((value & 0x7F) << 24);
value >>>= 7;
varInt |= (VARINT_CONTINUE_FLAG << 16);
varInt |= ((value & VARINT_MASK) << 24);
value >>>= VARINT_SHIFT;
if (value == 0) {
outputStream.write(varInt);
outputStream.write(varInt >> 8);
Expand All @@ -70,7 +76,7 @@ public void encode(Integer data, OutputStream outputStream) throws IOException {
return;
}

varInt |= (0x80 << 24);
varInt |= (VARINT_CONTINUE_FLAG << 24);
outputStream.write(varInt);
outputStream.write(varInt >> 8);
outputStream.write(varInt >> 16);
Expand All @@ -81,19 +87,19 @@ public void encode(Integer data, OutputStream outputStream) throws IOException {
@Override
public Integer decode(InputStream inputStream) throws IOException {
int b = inputStream.read();
int result = b & 0x7F;
if ((b & 0x80) != 0) {
int result = b & VARINT_MASK;
if ((b & VARINT_CONTINUE_FLAG) != 0) {
b = inputStream.read();
result |= (b & 0x7F) << 7;
if ((b & 0x80) != 0) {
result |= (b & VARINT_MASK) << VARINT_SHIFT;
if ((b & VARINT_CONTINUE_FLAG) != 0) {
b = inputStream.read();
result |= (b & 0x7F) << 14;
if ((b & 0x80) != 0) {
result |= (b & VARINT_MASK) << (VARINT_SHIFT * 2);
if ((b & VARINT_CONTINUE_FLAG) != 0) {
b = inputStream.read();
result |= (b & 0x7F) << 21;
if ((b & 0x80) != 0) {
result |= (b & VARINT_MASK) << (VARINT_SHIFT * 3);
if ((b & VARINT_CONTINUE_FLAG) != 0) {
b = inputStream.read();
result |= (b & 0x7F) << 28;
result |= (b & VARINT_MASK) << (VARINT_SHIFT * 4);
}
}
}
Expand Down