[GLUTEN-11513][VL][Iceberg] Fix input_file_name() on Iceberg, JNI init stability, and metadata propagation#11615
Conversation
…initialization for Velox
|
Run Gluten Clickhouse CI on x86 |
|
Here are the relevant test cases I ran BeforeAfter |
rui-mo
left a comment
There was a problem hiding this comment.
Hi @ReemaAlzaid, thanks for the fix. The Iceberg tests were disabled in the latest rebase, so we need to pause the review until they are restored, see #11630.
|
@jinchengchenghh Would you like to take a review? |
jinchengchenghh
left a comment
There was a problem hiding this comment.
Most of the commits looks good, let us wait for the test add back
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Please rebase, the iceberg test has been enabled in #11688 |
|
Run Gluten Clickhouse CI on x86 |
done |
|
Please resolve the CH CI, name and password is https://github.com/apache/incubator-gluten/blob/main/docs/get-started/ClickHouse.md#new-ci-system |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
I checked the CH CI failure on this branch does not appear to come from the Iceberg changes https://opencicd.kyligence.com/job/gluten/job/gluten-ci/19108/ From the log:
The actual failing tests are in
Both fail with This seems more like a Spark 3.5 ClickHouse test configuration gap than an issue caused by the Iceberg changes |
|
Could you rebase to see if the failure still exists? |
|
Run Gluten Clickhouse CI on x86 |
yeah still exists |
|
I find it is because following, search the keyword |
|
Run Gluten Clickhouse CI on x86 |
jinchengchenghh
left a comment
There was a problem hiding this comment.
Could you add a unit test like ScalarFunctionsValidateSuite?
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
I have added the test in Before: After: |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
What changes are proposed in this pull request?
This PR fixes
input_file_name(),input_file_block_start(),input_file_block_length()behavior on Iceberg with Velox and addresses a related JNI crash path.Issue: #11513
How was this patch tested?
Add unit test IcebergSuite.iceberg input_file_name
mvn -o -Pgluten-substrait,gluten-iceberg -DskipTests compileinput_file_name(),input_file_block_start(),input_file_block_length()and reproduction with Gluten Velox bundleRelated issue: #11513