Skip to content

fix: avoid dashmap deadlock for correlated queries#539

Merged
xushiyan merged 1 commit intoapache:mainfrom
xushiyan:fix-dead-lock
Mar 9, 2026
Merged

fix: avoid dashmap deadlock for correlated queries#539
xushiyan merged 1 commit intoapache:mainfrom
xushiyan:fix-dead-lock

Conversation

@xushiyan
Copy link
Member

@xushiyan xushiyan commented Mar 9, 2026

Description

  • Use include_str! to embed Avro schema files at compile time instead of runtime file I/O in delete.rs
  • Use read locks instead of write locks on DashMap in fs_view::collect_file_slices to avoid potential deadlocks during correlated queries; metadata loading is deferred to owned clones after locks are released

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added the bug Something isn't working label Mar 9, 2026
@xushiyan xushiyan added this to the release-0.5.0 milestone Mar 9, 2026
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.92%. Comparing base (29188ad) to head (742e165).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   84.91%   84.92%   +0.01%     
==========================================
  Files          73       73              
  Lines        4606     4597       -9     
==========================================
- Hits         3911     3904       -7     
+ Misses        695      693       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xushiyan xushiyan merged commit 441decb into apache:main Mar 9, 2026
15 checks passed
@xushiyan xushiyan deleted the fix-dead-lock branch March 9, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants