Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #2945 +/- ##
============================================
- Coverage 35.61% 1.57% -34.04%
+ Complexity 333 43 -290
============================================
Files 801 779 -22
Lines 67533 65018 -2515
Branches 8780 8332 -448
============================================
- Hits 24053 1026 -23027
- Misses 40916 63906 +22990
+ Partials 2564 86 -2478 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR enhances security for Arthas debugging endpoints by restricting remote access and standardizing configuration naming patterns across the codebase.
Changes:
- Added localhost-only access restriction to the store node's arthasstart endpoint
- Standardized Arthas configuration property names from snake_case to camelCase (e.g.,
arthas.telnet_port→arthas.telnetPort) - Changed default Arthas IP binding from
0.0.0.0to127.0.0.1and expanded disabled commands to includejad,ognl,vmtool
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| hugegraph-store/hg-store-node/src/main/resources/application.yml | Added Arthas configuration with localhost-only IP binding and expanded disabled commands |
| hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java | Added remote access check to arthasstart endpoint and new forbiddenMap helper method |
| hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/AppConfig.java | Updated default values for Arthas IP and disabled commands |
| hugegraph-server/hugegraph-dist/src/assembly/static/conf/rest-server.properties | Renamed Arthas properties to camelCase and updated default values |
| hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java | Updated default values for Arthas IP binding and disabled commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Show resolved
Hide resolved
...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-dist/src/assembly/static/conf/rest-server.properties
Show resolved
Hide resolved
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Currently, the configuration keys in rest-server.properties use snake_case (e.g., server_port), which is inconsistent with the naming convention expected by ServerOptions.java. This mismatch causes the following issues:
Terminal logs show warnings such as: "arthas.xxxx is redundant ...", indicating that the properties are not being recognized or registered.


