DRAFT/Experiment to see how encrypted reads might look #2042
+3,323
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanderbailey
commented
Jan 17, 2026
| .with_preload_page_index(should_load_page_index); | ||
|
|
||
| // Check if file is encrypted but encryption feature is not enabled | ||
| #[cfg(not(feature = "encryption"))] |
Author
There was a problem hiding this comment.
Not sure if we want this or not...
xanderbailey
commented
Jan 17, 2026
| let result = std::thread::scope(|s| { | ||
| s.spawn(|| { | ||
| handle.block_on(async move { | ||
| encryption_manager.prepare_decryption(&key_metadata).await |
Author
There was a problem hiding this comment.
prepare_decryption is async so we need the tokio Handle here to call the async function in a sync context...
xanderbailey
commented
Jan 17, 2026
| let result = std::thread::scope(|s| { | ||
| s.spawn(|| { | ||
| handle.block_on(async move { | ||
| encryption_manager.prepare_decryption(&key_metadata).await |
Author
There was a problem hiding this comment.
prepare_decryption is async so we need the tokio Handle here to call the async function in a sync context...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
I just wanted to experiment to see how it might look to read encrypted manifests, manifest lists and parquet.
Working towards #2034
What changes are included in this PR?
Are these changes tested?