Spark 4.1: Fix IcebergSource doc#15359
Conversation
There was a problem hiding this comment.
nit: maybe cache catalog instead of rewrite catalog?
There was a problem hiding this comment.
It is actually called SparkRewriteTableCatalog and is used exclusively for rewrites.
There was a problem hiding this comment.
I have reworded it to be clear.
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, thanks @aokolnychyi !
There was a problem hiding this comment.
[doubt] interesting : what happens when the namespace name is same as that of the catalog ? i comment states it catalog, i wonder why we did that in first place
There was a problem hiding this comment.
We delegate to Spark and Spark always picks the first name part as catalog if there is a catalog with that name.
There was a problem hiding this comment.
minor :
| * <li>{@code "cat.ns.tbl"} - {@code ns.tbl} from the specified catalog | |
| * <li>{@code "cat.ns.tbl"} - {@code ns.tbl} from the specified catalog and namespace |
There was a problem hiding this comment.
Reworded this piece a bit.
|
Thanks, @huaxingao @singhpk234! |
3 participants
This PR fixes
IcebergSourcedoc.