Take Throwable#toString() into account while rendering stack traces in Pattern Layout#4033
Take Throwable#toString() into account while rendering stack traces in Pattern Layout#4033vy merged 5 commits intoapache:2.xfrom
Throwable#toString() into account while rendering stack traces in Pattern Layout#4033Conversation
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowableStackTraceRenderer.java
Show resolved
Hide resolved
|
Hi, @vy Would love to get your eyes on this when you get a moment. |
vy
left a comment
There was a problem hiding this comment.
Could you add a changelog entry and make sure ./mvnw verify -pl :log4j-core,:log4j-core-test passes, please?
...-test/src/test/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverterTest.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverterTest.java
Outdated
Show resolved
Hide resolved
|
Could you replace the entire |
Signed-off-by: Jongmin Chung <chungjm0711@gmail.com>
Signed-off-by: Jongmin Chung <chungjm0711@gmail.com>
a5a2c82 to
16eb60b
Compare
As this is my first PR, I wanted to provide more background context. I've shortened it now. |
vy
left a comment
There was a problem hiding this comment.
@JongminChung, thanks for the update.
Please, don't ever force-push. It completely nukes all the conversation history.
Would you also mind adding a changelog entry file, please?
...-test/src/test/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverterTest.java
Outdated
Show resolved
Hide resolved
Throwable#toString() into account while rendering stack traces in Pattern Layout
Signed-off-by: Jongmin Chung <chungjm0711@gmail.com>
Sorry, I deleted them thinking they were unnecessary commitments through force-push, but I overlooked that the context of the previous conversation disappeared. Regarding the changelog you requested, I will read the document and write it. Thank you for reviewing it in detail every time. |
Signed-off-by: Jongmin Chung <chungjm0711@gmail.com>
Align renderThrowableMessage(...) to use Throwable.toString(), restoring the default printStackTrace() behavior documented for the %ex converter.
%expattern andexceptionJTL resolver #3623.Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (the build instructions)src/changelog/.2.x.xdirectory