-
Notifications
You must be signed in to change notification settings - Fork 972
[QDP] Add NumPy state vector documentation to QDP API #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
cc @ryankert01 |
|
@rich7420 I don't think numpy pr is merged or created right now |
|
agree. I think we could turn into draft waiting for numpy reader being merged. |
|
Btw you may need to reopen a pr to target it to dev-qdp |
|
Thank you for the guidance. |
|
@Rutuja123-dos thanks for the patch! |
|
And please ask if someone is doing this before pushing a pr, it is not polite to just take over. |
|
Thank you for pointing that out |
| - `ancilla_qubit` (int, default to 0): Index of the ancilla qubit. | ||
| - **Usage**: Convenience wrapper for fidelity/overlap measurement across backends. | ||
|
|
||
| ## NumPy Usage in QDP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might have a seperate QDP page in the docs, so I think we probably don't want to do it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
cc @rich7420 @guan404ming to close this issue? it should be in dev-qdp branch |
|
And I believe the numpy part is still wip, you should wait till its finished to work on this issue. |
Purpose of PR
This PR adds documentation describing how NumPy arrays are used
to represent quantum state vectors in QDP.
It includes:
Fixes #723.
Related Issues or PRs
Closes #723
Changes Made
Breaking Changes
Checklist