Skip to content

Conversation

@michael-o
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSITE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSITE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o michael-o requested review from cstamas, gnodet and olamy and removed request for cstamas November 19, 2024 10:34
@michael-o
Copy link
Member Author

This PR is intended to create a MVP, not full port.

@michael-o
Copy link
Member Author

michael-o commented Nov 19, 2024

This works, but causes IT failures...

[ERROR] The following builds failed:
[ERROR] *  MSITE-504/pom.xml
[ERROR] *  MSITE-354/pom.xml
[ERROR] *  MSITE-484/pom.xml
[ERROR] *  MSITE-506/pom.xml
[ERROR] *  MSITE-644/pom.xml
[ERROR] *  MSITE-609/pom.xml
[ERROR] *  default-reports/pom.xml
[ERROR] *  MSITE-842/pom.xml
[ERROR] *  inheritedReports/pom.xml
[ERROR] *  inheritance-interpolation/pom.xml
[ERROR] *  site-deploy/pom.xml
[ERROR] *  site-sd-stagingSiteURL/pom.xml

@jira-importer
Copy link

Resolve #1151

@slachiewicz slachiewicz changed the title [MSITE-1028] Upgrade to Maven 4.0.0-beta-5 [MSITE-1028] Upgrade to Maven 4.0.0-rc4 Oct 19, 2025
@michael-o
Copy link
Member Author

@slachiewicz Thank you for picking this up!

@slachiewicz
Copy link
Member

a bit less failures, some bit strange.
look like migration to mvn 4 is painfull for plugin :(

@michael-o
Copy link
Member Author

a bit less failures, some bit strange. look like migration to mvn 4 is painfull for plugin :(

Maybe the components below need to be touched first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants