xtensa/esp32s3: fix dcache flush error in up_flush_dcache #17753
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: xtensa
terry0012
force-pushed
the
esp32s3_dcache
branch
from
2b32790 to
e8c785a
Compare
The items is not used in up_flush_dcache, and we should use it in function cache_invalidate_dcache_items. Signed-off-by: rongyichang <rongyichang@xiaommi.com>
terry0012
force-pushed
the
esp32s3_dcache
branch
from
e8c785a to
fbd612f
Compare
acassis
approved these changes
Dec 31, 2025
Contributor
|
We will have a look, please do not merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In up_flush_dcache, items is not used, and we should use it in cache_invalidate_dcache_items.
extern void cache_invalidate_dcache_items(uint32_t addr, uint32_t items);And this will cause lvgl crash in apache/nuttx-apps#3253
Impact
None
Testing
lckfb-szpi-esp32s3 board