feat(services/memcached): Support connection via unix domain socket #7112
+247
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch dependency from `http` to `url` for endpoint parsing. - Introduce `SocketStream` to handle both `TcpStream` and `UnixStream`.
dosubot
bot
added
size:L
- Add `#[cfg(unix)]` checks for UnixSocket usage. - Refactor connection manager to use `Endpoint` enum.
Contributor
Author
|
This is a small change and shouldn't affect existing logic. |
Contributor
Author
|
Hello, can you take a look? @Xuanwo |
Xuanwo
reviewed
Jan 19, 2026
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this. The change looks good to me, but it lacks service test coverage. Could you add a test here to connect Memcached with a socket?
https://github.com/apache/opendal/tree/main/.github/services/memcached
- Add docker-compose-memcached-unix.yml for Unix socket setup - Add memcached_with_unix action for CI testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Currently, the
memcachedservice only supports TCP connections. However, in many local or containerized environments, connecting via Unix Domain Sockets (UDS) is preferred for better performance or security.This PR introduces support for UDS and refactors the connection logic to handle different transport protocols uniformly.
What changes are included in this PR?
httptourlcrate for more flexible endpoint parsing (specifically for non-HTTP schemes likeunix).SocketStreamenum to unifyTcpStreamandUnixStreamimplementations underAsyncReadandAsyncWrite.unix://schemes and support local socket paths.Are there any user-facing changes?
Yes. Users can now configure the
endpointwith theunixscheme to connect via a Unix Domain Socket.Example:
unix:///tmp/memcached.sockExisting TCP configurations (e.g.,
127.0.0.1:11211) remain unaffected.AI Usage Statement
This PR was developed with assistance from GitHub Copilot (Claude Opus 4.5).