HDDS-14279. Double check selected container state before move process starts #9575
+84
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenSammi
reviewed
Dec 31, 2025
| // Container state may have changed after selection. | ||
| // Only CLOSED and QUASI_CLOSED containers can be moved. | ||
| State containerState = container.getContainerData().getState(); | ||
| if (containerState != State.CLOSED && containerState != State.QUASI_CLOSED) { |
Contributor
There was a problem hiding this comment.
In DefaultContainerChoosingPolicy#chooseContainer, only CLOSED state container is selected, QUASI_CLOSED container is used in test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The container choose and container actual move is two procedures. There is chance that container state is changed after container is selected, for example, container is moved to deleted state. So need to double check the container state again before acquire the container lock to start the move process.
Container should be moved only if they are in CLOSED or QUASI_CLOSED state.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14279
How was this patch tested?
Added new unit test in
TestDiskBalancerTask