HDDS-14293. Improve Dynamic Property Reload documentation #9582
+178
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @vyalamar for working on this, left few comments
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
- Added ozone.readonly.administrators to OM and SCM - Added ozone.key.deleting.limit.per.task to OM - Added ozone.directory.deleting.service.interval to OM - Added ozone.thread.number.dir.deletion to OM - Added ozone.snapshot.filtering.service.interval to OM - Added hdds.datanode.block.delete.threads.max to Datanode - Added ozone.block.deleting.service.workers to Datanode - Added ozone.block.deleting.service.interval to Datanode - Added ozone.block.deleting.service.timeout to Datanode - Added hdds.datanode.replication.streams.limit to Datanode
Author
|
@sreejasahithi Can you please check. I have addressed all your comments. |
Author
|
@sreejasahithi Can you please look into apache/ozone-site#217 |
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @vyalamar for updating the patch. Left few minor comments
Could you please also add in the doc that --address must be specified if --in-service-datanodes is not given.(even though your examples do show this)
|
|
||
| ```shell | ||
| $ ozone admin reconfig --service=DATANODE --in-service-datanodes properties | ||
| Datanode: Node [hadoop1:19864] Reconfigurable properties: |
Contributor
There was a problem hiding this comment.
it should be
Suggested change
| Datanode: Node [hadoop1:19864] Reconfigurable properties: | |
| DN: Node [hadoop1:19864] Reconfigurable properties: |
| command: | ||
| ```shell | ||
| ozone admin reconfig --service=[OM|SCM|DATANODE] --address=<ip:port> start|status|properties | ||
| ozone admin reconfig --service=[OM|SCM|DATANODE] --address=<ip:port> <operation> |
Contributor
There was a problem hiding this comment.
--address can be <ip:port> or <hostname:port>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves the Dynamic Property Reload (Reconfigurability) documentation:
ozone.administrators)ozone.example.configwith actual DataNode propertyhdds.datanode.block.deleting.limit.per.intervalWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14293
How was this patch tested?
This is a documentation-only change. Verified that the markdown renders correctly locally.