HealthCheckRoutes Provider, so user can add it to their own server#320
HealthCheckRoutes Provider, so user can add it to their own server#320shakeeb-upstart wants to merge 6 commits intoapache:mainfrom
Conversation
…utes and add it to their own server
management/src/main/scala/org/apache/pekko/management/HealthCheckRoutes.scala
Outdated
Show resolved
Hide resolved
management/src/main/scala/org/apache/pekko/management/HealthCheckRoutes.scala
Show resolved
Hide resolved
management/src/main/scala/org/apache/pekko/management/HealthCheckRoutes.scala
Outdated
Show resolved
Hide resolved
management/src/main/scala/org/apache/pekko/management/HealthCheckRoutes.scala
Outdated
Show resolved
Hide resolved
|
@shakeeb-upstart would you be able to add a unit test for regression purposes? |
| override def routes(mrps: ManagementRouteProviderSettings): Route = routes() | ||
|
|
||
| /** | ||
| * @since 1.1.0 |
There was a problem hiding this comment.
1.1.0 was already released so we need to decide whether this can go in 1.1.1 or if we need a 1.2.0 before this can be released
There was a problem hiding this comment.
not much point changing this yet - but I will block the merge until we can discuss how to eventually release this (which affects which branch we can use)
There was a problem hiding this comment.
yes sure, let me know if I am needed for any part in the discussion.
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
Would PekkoManagement(sys).routes not work in your case? do you really need explicitly the health check routes without any other Management routes?
| * @since 1.1.0 | ||
| */ | ||
| object HealthCheckRoutes extends ExtensionId[HealthCheckRoutes] with ExtensionIdProvider { | ||
| override def get(system: ActorSystem): HealthCheckRoutes = super.get(system) |
There was a problem hiding this comment.
returning it here means HealthCheckRoutes is becoming public API, so we should remove the 'internal' markers.
3 participants
Created an extension provider for HealthCheckRoutes, so users can get the routes and add it to their own server