feat(console): Make OAuth token URL configurable #136
Conversation
Fixes apache#98 Make the OAuth token URL configurable via VITE_OAUTH_TOKEN_URL environment variable to support integration with 3rd party providers like Keycloak. Changes: - Use config.OAUTH_TOKEN_URL in auth.ts with fallback to default - Document VITE_OAUTH_TOKEN_URL in . env.example and README. md - Add Keycloak integration example and configuration guide - Update Dockerfile to include VITE_OAUTH_TOKEN_URL environment variable - Support both build-time and runtime configuration Defaults to '/api/catalog/v1/oauth/tokens' for backward compatibility. See: https://github.com/jbonofre/polaris-tools/tree/keycloak-support
.../src/test/java/org/apache/polaris/appruner/maven/mavenit/ITSimulatingTestUsingThePlugin.java
Show resolved
Hide resolved
binarycat0
left a comment
binarycat0
left a comment
There was a problem hiding this comment.
Thanks for the contribution and for taking the time to work on this PR — it’s appreciated.
I noticed that this change includes several updates that seem unrelated or redundant with respect to the main purpose of the PR. To help keep reviews focused and maintainable, could you please reduce the scope to only the changes strictly required for the intended fix/feature?
Since this repository is maintained under the Apache Polaris community, we also try to follow the Apache contribution guidelines closely. In particular, it would be great if you could align this PR with the code contribution guidelines described here:
https://polaris.apache.org/community/contributing-guidelines/#code-contribution-guidelines
Narrowing the changeset and following these guidelines will make it much easier for the community to review and merge the contribution.
Thanks again for your effort, and please let us know if anything in the guidelines is unclear.
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # regarding copyright ownership. The ASF licenses this file |
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # under the License. |
|
|
||
| # Build stage | ||
| FROM registry.access.redhat.com/ubi9/nodejs-22-minimal:9.7-1767673763 AS builder | ||
| FROM node:22-slim AS builder |
There was a problem hiding this comment.
AFAIK this image was used in purpose.
Please check this PR - 34e63e6
|
|
||
| # Copy package files | ||
| COPY package.json ./ | ||
| COPY package. json ./ |
if i am not wrong please confirm that i have to Revert to Red Hat UBI image?? |
I consider this change as not meeting the main purpose of this PR. Besides that please review your changes, it contains many additional whitespaces and non ASCII chars, all around the codebase. |
4 participants
Fixes #98
Make the OAuth token URL configurable via VITE_OAUTH_TOKEN_URL environment variable to support integration with 3rd party providers like Keycloak.
Changes:
Defaults to '/api/catalog/v1/oauth/tokens' for backward compatibility.