Skip to content

[fix][ml] Fix NoSuchElementException in EntryCountEstimator caused by a race condition #25177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lhotari wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[fix][ml] Fix NoSuchElementException in EntryCountEstimator caused by a race condition #25177

lhotari wants to merge 4 commits into from
+74 −11

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jan 22, 2026

Fixes #25174

Motivation

An NoSuchElementException could occur in EntryCountEstimator, causing dispatching to stop.
This condition could happen as a result of a race condition caused by ledger trimming. The ledgersInfo map appear to be be empty.

Modifications

  • check if ledgersInfo map is empty
  • catch NoSuchElementException when firstKey or lastKey is accessed to avoid race conditions after checking if the map was empty
  • add tests

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.2.0 milestone Jan 22, 2026
@lhotari lhotari self-assigned this Jan 22, 2026
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 22, 2026
@lhotari lhotari added release/3.0.16 release/4.0.9 release/4.1.3 and removed doc-not-needed Your PR changes do not impact docs labels Jan 22, 2026
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 22, 2026
@lhotari lhotari mentioned this pull request Jan 22, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@nodece nodece Awaiting requested review from nodece

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

@dao-jun dao-jun Awaiting requested review from dao-jun

1 more reviewer

@Shawyeok Shawyeok Shawyeok left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@lhotari lhotari

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.16 release/4.0.9 release/4.1.3

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

[Bug][Broker] Escaped NoSuchElementException exception throw in EntryCountEstimator causes dispatcher to stop dispatching messages

2 participants

@lhotari @Shawyeok