Skip to content

Conversation

@lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #9980

Brief Description

How Did You Test This Change?

Signed-off-by: terrance.lzm <terrance.lzm@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2026

Codecov Report

❌ Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.73%. Comparing base (1117ab8) to head (db37623).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...apache/rocketmq/broker/pop/PopConsumerService.java 55.55% 1 Missing and 3 partials ⚠️
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9981      +/-   ##
=============================================
- Coverage      48.85%   48.73%   -0.12%     
+ Complexity     12769    12744      -25     
=============================================
  Files           1324     1324              
  Lines          96405    96415      +10     
  Branches       12434    12437       +3     
=============================================
- Hits           47094    46988     -106     
- Misses         43568    43667      +99     
- Partials        5743     5760      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit 9f23894 into apache:develop Jan 7, 2026
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Skip invalid records when the group is absent in Pop

4 participants