Have date chooser dispatch month change events#53
Closed
justinmclean wants to merge 11 commits intoapache:developfrom
Closed
Have date chooser dispatch month change events#53justinmclean wants to merge 11 commits intoapache:developfrom
justinmclean wants to merge 11 commits intoapache:developfrom
Conversation
This reverts commit 2ec5304.
Member
Author
|
Note as other pull request have not been accepted yet this pull request contains some extra changes and my need to be modified. I can't see any easy way of fixing this as those changes were made in my develop branch. |
Contributor
|
I'm looking over the changes. Why does "displayedMonthChanged" need to change to "monthChanged"? I know that adding the [Event] metadata to DateChooser is necessary, but I don't see why the event names had to change. Was there a conflict? |
Member
Author
|
To make the event handler name more in line with other event handler names. See my email on the dev list can change the event name back if you think it's a better fit. |
Member
Author
|
Reopens as PR #100 to remove commit history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example code:
<js:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
xmlns:js="library://ns.apache.org/royale/basic">
</js:Application>