[Experimental] Expose Prometheus metrics directly from Solr with prometheus client #2375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-10654
Description
Experimental PR not meant for merging. Incomplete code.
This PR created a new response writer that directly transforms and bridges dropwizard to prometheus metrics 1 to 1.
/solr/admin/metrics?wt=prometheusBiggest issue is that 1 to 1 makes these metrics basically useless and an anti-pattern to prometheus naming that the
prometheus exporterwould take care of. This stems from the fact that Dropwizard doesn't have the support of tags/labels.E.g
Dropwizard to Prometheus:
"QUERY./select.requests":0->QUERY__select_requests 0.0Prometheus Exporter:
solr_metrics_core_requests_total{category="QUERY",handler="/select",core="xyz_shard1_replica_t1",collection="xyz",shard="shard1",replica="replica_t1",base_url="localhost:8983/solr",}Would need to find some way to either parse the dropwizard registry and append tags to them with prometheus or add new way that Solr collects metrics and creates labels (prometheus_client registry in parallel or possibly over engineered effort?)