Conversation
…t inference and subprojects discovery
|
In some POMs we're using tabs for indentation, while in others we have double spaces. Should we agree on a common style and update them? |
|
Thx. Can we update the action to run with an actual Maven 4 binary? Most likely other ASF projects are doing it similar or https://github.com/s4u/setup-maven-action?tab=readme-ov-file or alike are already Maven 4 ready? I have no preference regarding formatting. |
| <packaging>pom</packaging> | ||
|
|
||
| <dependencies> | ||
| <subprojects> |
There was a problem hiding this comment.
In RC 5, you can no longer have submodules together with jar packaging, so I updated accordingly.
| with: | ||
| distribution: adopt | ||
| java-version: 17 | ||
| - name: Install Maven 4 |
There was a problem hiding this comment.
This was the easiest way I found to build with specific maven 4 versions. @rzo1 I think that the GitHub action you shared didn't work due to ASF restrictions on action repositories.
There was a problem hiding this comment.
Looks good. I think we can make progress with the PR once Maven 4 is officially released, but the PR shows, that we are ready for it.
Alterantive would be to start a discussion on dev@, if we want to switch to Maven 4 RC's for building SC. WDYT?
I am fine with it. I think we have checkstyle enabled, so maybe something for it to cover? |
That's a good point. I will have a look. |
Taken care of in #1776 |
#1662 Changes for Maven 4 compatibility following the official migration guidelines 1|2.
Steps followed:
mvnup apply --model-version 4.1.0 --all