Skip to content

fix: prevent orphaned sessions when lakeFS abort fails #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuang7 wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −17
Open

fix: prevent orphaned sessions when lakeFS abort fails #4197

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f61ab9
update
xuang7 Feb 8, 2026
f42927c
update.
xuang7 Feb 9, 2026
b84bb88
Merge branch 'main' into fix/multipart-abort-cleanup
xuang7 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1994,7 +1994,7 @@ class DatasetResource {
URLDecoder.decode(encodedFilePath, StandardCharsets.UTF_8.name())
)

withTransaction(context) { ctx =>
val (repoName, uploadId, physicalAddr) = withTransaction(context) { ctx =>
if (!userHasWriteAccess(ctx, did, uid)) {
throw new ForbiddenException(ERR_USER_HAS_NO_ACCESS_TO_DATASET_MESSAGE)
}
Expand Down Expand Up @@ -2030,21 +2030,6 @@ class DatasetResource {
}

val physicalAddr = Option(session.getPhysicalAddress).map(_.trim).getOrElse("")
if (physicalAddr.isEmpty) {
throw new WebApplicationException(
"Upload session is missing physicalAddress. Restart the upload.",
Response.Status.INTERNAL_SERVER_ERROR
)
}

withLakeFSErrorHandling {
LakeFSStorageClient.abortPresignedMultipartUploads(
dataset.getRepositoryName,
filePath,
session.getUploadId,
physicalAddr
)
}

// Delete session; parts removed via ON DELETE CASCADE
ctx
Expand All @@ -2057,8 +2042,14 @@ class DatasetResource {
)
.execute()

Response.ok(Map("message" -> "Multipart upload aborted successfully")).build()
(dataset.getRepositoryName, session.getUploadId, physicalAddr)
}

withLakeFSErrorHandling {
LakeFSStorageClient.abortPresignedMultipartUploads(repoName, filePath, uploadId, physicalAddr)
}

Response.ok(Map("message" -> "Multipart upload aborted successfully")).build()
}

/**
Expand Down