Conversation
tsqa/conf_plugin.py
Outdated
There was a problem hiding this comment.
This will probably need to follow the same server_ports markup that we have in records.config-- since ATS ports have different attributes associated with them (such as ipv4:443 -- https://docs.trafficserver.apache.org/en/latest/reference/configuration/records.config.en.html#proxy-config-http-server-ports)
…g to comply with ATS settings
tsqa/environment.py
Outdated
There was a problem hiding this comment.
Are both if checks necessary? And if so, can we put them in one line?
|
@cynthiagu23 Few comments left unfixed, once those are taken care of I think we are good to merge :) |
There was a problem hiding this comment.
is ZPL compatible with Apache?
There was a problem hiding this comment.
i think all we have to do, is add this notice to the NOTICE file, like we do in ats itself
https://github.com/apache/trafficserver/blob/master/NOTICE
add 3 configurations for the environment: