Fix improper check for mbrlen/mblen, to deal with the configuration failure for Android below API level 26#56
Open
zjyhjqs wants to merge 1 commit intoapache:masterfrom
Open
Fix improper check for mbrlen/mblen, to deal with the configuration failure for Android below API level 26#56zjyhjqs wants to merge 1 commit intoapache:masterfrom
mbrlen/mblen, to deal with the configuration failure for Android below API level 26#56zjyhjqs wants to merge 1 commit intoapache:masterfrom
Conversation
The usage place (`IconvLCPTranscoder::calcRequiredSize`) will check the existence of `::mbrlen` first. If not then use the `::mblen` as alternative. NDK doesn't provide the implementation of `::mblen` below API level 26. Only checks `HAVE_MBLEN` would consequence to configuration failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I know this is not a GitHub project. But my application for JIRA account hasn't been replied yet.)
The usage place (
IconvLCPTranscoder::calcRequiredSize) will check the existence of::mbrlenfirst. If not then use the::mblenas alternative.xerces-c/src/xercesc/util/Transcoders/Iconv/IconvTransService.cpp
Lines 237 to 241 in 5fe4f4b
NDK doesn't provide the implementation of
::mblenbelow API level 26. Only checksHAVE_MBLENwould consequence to configuration failure.