-
-
Notifications
You must be signed in to change notification settings - Fork 81
OpenTelemetry Metrics layer #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry Metrics layer #663
Conversation
geofmureithi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution!
There is only some small changes requested mainly to avoid confusion between job, message, and request. To do so, we prefer to use task as a general term, job for mutable requests and message for immutable requests.
|
Also:
|
47aae4d to
fb2a246
Compare
fb2a246 to
6d7c832
Compare
|
Thank you for clearing up the terminology. I've made the changes you requested and rebased on main. On the topic of metric names, OpenTelemetry have a catalogue of semantic conventions for choosing metric names. For example, axum-otel-metrics uses the HTTP Semantic Conventions with metric names like There aren't any semantic conventions for task scheduler metrics but the General guidelines recommend we consider prior art when choosing metric names. The Messaging conventions are designed with queues in mind and might fit apalis. Based on my understanding, we would get these metric names
These semantic conventions also come with required attributes. Let me know if this changes your mind on the metric names for the otel layer. |
|
Let me know how I can help with the security audit. |
geofmureithi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this contribution
Hey again,
We've using OpenTelemetry to track our task metrics. We couldn't adapt this metrics adapter to work: https://github.com/DoumanAsh/metrics-opentelemetry so we created this layer.
We'd love for it to be merged upstream. Let me know how I can help it happen.
Cheers,
Liam